Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSDAO refactoring: use 'getDelegatorPools' getter instead of 'getStakerPools' in Staking DApp #3612

Merged
merged 4 commits into from Feb 9, 2021

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Feb 8, 2021

Motivation

This is a small refactoring PR that reflects the changes made in poanetwork/posdao-contracts@2994441. It is part of big refactoring in POSDAO contracts to add there an ability for changing pool's stakingAddress/miningAddress. We'll be making the changes step-by-step in small portions like this one.

Please, don't merge and publish Blockscout release with these changes until we upgrade the StakingAuRa contract to apply the changes. I'll let you know once that happens.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Feb 8, 2021

Pull Request Test Coverage Report for Build 8c7de255fa36188bfe5c9be244de85ad14bcefb2-PR-3612

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 86 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.9%) to 64.8%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/checksum_address.ex 6 55.56%
lib/block_scout_web/channels/stakes_channel.ex 80 0%
Totals Coverage Status
Change from base Build 7944cc535fddc0882043a717d85caec487db9bfb: 1.9%
Covered Lines: 2095
Relevant Lines: 3233

💛 - Coveralls

@varasev varasev requested a review from vbaranov February 8, 2021 14:51
@varasev
Copy link
Contributor Author

varasev commented Feb 9, 2021

Now we can merge it to master

@vbaranov vbaranov merged commit 0f54f4d into master Feb 9, 2021
@vbaranov vbaranov deleted the va-staker-pools-to-delegator-pools branch February 9, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants