Gas token integration #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Mar 9, 2020
|
Does it make sense to update oracle-e2e tests in the tokenbridge monorepo in order to check that the oracle handles such transactions properly? |
akolotov
reviewed
Mar 12, 2020
There was a problem hiding this comment.
Please share your view on new comments and on #378 (comment). Then, seems that we can approve the PR.
|
For now, I don't think that we need explicit e2e tests for oracle. |
akolotov
approved these changes
Mar 12, 2020
patitonar
reviewed
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality of minting gas tokens inside
requireToPassMessagecall of foreign AMB bridgeCloses #363.