Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderTarget: tab no longer works #134

Closed
sysofwan opened this issue Jan 4, 2022 · 5 comments · Fixed by #135
Closed

renderTarget: tab no longer works #134

sysofwan opened this issue Jan 4, 2022 · 5 comments · Fixed by #135
Assignees
@pocka
Labels
category: bug Something isn't working

Comments

@sysofwan
Copy link

sysofwan commented Jan 4, 2022 •
edited
Loading

Describe the bug

Usage with tab rendering no longer works in the demo here.

I suspect this is caused by this PR. I think the tab addons does not support function titles.

How to reproduce the bug?

  1. Navigate to tab demo here.
  2. Observe that design tab does not render.

Expected behaviour

Design tab should render

Affected versions

6.1.0

Storybook versions

6.4.9
@sysofwan sysofwan added the category: bug Something isn't working label Jan 4, 2022
@pocka pocka self-assigned this Jan 6, 2022
pocka added a commit that referenced this issue Jan 6, 2022
@pocka
fix: Use static tab name for renderTarget=tab
1dec80c 
#134

It seems the Tab title does not accept function title. With Storybook
running with NODE_ENV=development, React emits an error saying it
cannot handle the function.
@pocka pocka mentioned this issue Jan 6, 2022
Merged
@pocka pocka closed this as completed in #135 Jan 6, 2022
@pocka
Copy link
Collaborator

pocka commented Jan 6, 2022

Thank you for reporting. I released storybook-addon-designs@v6.2.1, which includes a patch for the bug.

@sysofwan
Copy link
Author

sysofwan commented Jan 6, 2022

Thank you!

@Drakogangcom

This comment was marked as spam.

Sign in to view
@ThomasCarca
Copy link

Hello this seems broken again in the latest version. We had to revert to v6.2.1 where it seems to work just fine.

@pocka
Copy link
Collaborator

pocka commented May 26, 2023 •
edited
Loading

Would you mind opening a new issue?

@ThomasCarca ThomasCarca mentioned this issue May 26, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pocka pocka

Labels
category: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use static tab name for renderTarget=tab storybookjs/addon-designs
4 participants
@sysofwan @pocka @ThomasCarca @Drakogangcom