Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with rubocop versions >= 0.70 #11

Closed
wants to merge 13 commits into from

Conversation

kennethteh90
Copy link

@kennethteh90 kennethteh90 commented Aug 31, 2020

  • Adds compatibility with rubocop versions >= 0.70
  • Adds spec that works using expect_offense

Closes #10

@pocke
Copy link
Owner

pocke commented Sep 18, 2020

Thanks for your pull request, and sorry for the delay.
But I do not maintain this plugin actively now, so I will not merge it.

I recommend opening a pull request or an issue to add the cop to rubocop-rails project if you need it. You can use the code in this repository under the LICENSE.

Personally I think this feature is acceptable for rubocop-rails, because it already has a similar cop that orders callbacks. https://github.com/rubocop-hq/rubocop-rails/blob/7098462525bec5f16bb6ce9e3e62907862319db8/lib/rubocop/cop/rails/active_record_callbacks_order.rb

I'll archive this repository after a while.

Thanks.

@kennethteh90
Copy link
Author

Thanks for the reply! I understand and thank you for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For new rubocop
2 participants