Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#98 Add support for style attribute #99

Merged
merged 2 commits into from Nov 13, 2020
Merged

#98 Add support for style attribute #99

merged 2 commits into from Nov 13, 2020

Conversation

omarmiatello
Copy link
Contributor

@omarmiatello omarmiatello commented Oct 9, 2020 •
edited

Issue: #98 Add support for style attribute

Context

The plugin cannot handle a layout with a style attribute (like ?selectableItemBackground)

Changes

Convert attributes like ?selectableItemBackground in imageAttribute(selectableItemBackground)

pocmo
pocmo reviewed Oct 19, 2020
View reviewed changes
Copy link
Owner

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. 👍

Can you also add a test to ComposerTest to make sure the Kotlin output is what we expect? :)

@pocmo pocmo merged commit 61d8487 into pocmo:main Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocmo pocmo pocmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omarmiatello @pocmo