Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for chrome's Global Media Control (MediaSession) #38

Closed
3 tasks done
dellagustin opened this issue Jan 19, 2020 · 4 comments
Closed
3 tasks done

Support for chrome's Global Media Control (MediaSession) #38

dellagustin opened this issue Jan 19, 2020 · 4 comments
Assignees
Labels
bug enhancement grooming Needs grooming ux User experience
Projects

Comments

@dellagustin
Copy link
Contributor

dellagustin commented Jan 19, 2020

as shown on the image below, chrome introduced a central user interface for media control (finally! I wanted something like that for a long time...)

We probably need to consume some API (I need to check the documentation) to provide the metadata.
image

I already identified some bugs related to it:

  • in our player, the UI does not properly react when the control is changed with that button.
    • This does not seem to be happening anymore
  • when I click the podstation entry on the media controller, it does not navigate to podStation (this was actually not expected to work in the first place, as podStation's audio element is actually on the background page, since it has to remain playing when the tab is closed). - created a issue just for this - Clicking on the Global Media Control entry does not navigate to a podStation window #55
  • using the stop function on the player does not remove the media session from the global media control - solved with b7b03ab

I plan to create issues for these in separate, for the meantime, I will also label this issue as bug.

some news about it: https://techcrunch.com/2020/01/16/chrome-gets-global-media-controls/

More refs:
https://w3c.github.io/web-roadmaps/media/control.html
https://w3c.github.io/mediasession
https://developer.mozilla.org/en-US/docs/Web/API/Media_Session_API
https://github.com/w3c/mediasession/blob/master/explainer.md

@dellagustin dellagustin added enhancement grooming Needs grooming ux User experience labels Jan 19, 2020
@dellagustin dellagustin self-assigned this Jan 19, 2020
@dellagustin dellagustin pinned this issue Jan 19, 2020
@dellagustin dellagustin added this to Needs Grooming in podStation Jan 19, 2020
@dellagustin
Copy link
Contributor Author

dellagustin commented Jan 21, 2020

in our player, the UI does not properly react when the control is changed with that button.
seems to be actually working, but with a delay, which indicates the update is coming from the timer, still needs some investigation...

I retested and this seems to be working, but not intentionally

@dellagustin
Copy link
Contributor Author

Current screenshot after e84bf69

image

@dellagustin dellagustin changed the title Support for chrome's new media control Support for chrome's Global Media Control (MediaSession) Jan 25, 2020
@dellagustin
Copy link
Contributor Author

Current screenshot after 4fb90eb

image

@dellagustin dellagustin moved this from Needs Grooming to Blocked in podStation Jan 25, 2020
@dellagustin
Copy link
Contributor Author

blocked by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement grooming Needs grooming ux User experience
Projects
podStation
  
Done
Development

No branches or pull requests

1 participant