Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UMM-S record for hydrocron #77

Closed
frankinspace opened this issue Jan 10, 2024 · 6 comments · Fixed by #109
Closed

Create UMM-S record for hydrocron #77

frankinspace opened this issue Jan 10, 2024 · 6 comments · Fixed by #109
Assignees
Labels
enhancement New feature or request

Comments

@frankinspace
Copy link
Member

Hydrocron is a new service being offered and should have a UMM-S record created describing what the service is.

AC:

  • UMM-S JSON file created and checked in to repo
  • Github workflow step added which updates UMM-S record as part of CICD
@nikki-t
Copy link
Collaborator

nikki-t commented Feb 22, 2024

@frankinspace and @torimcd - Can you take a look at the UMM-S JSON file I created and let me know if it fulfills all of the requirements for UMM-S records? And if it does, what are next steps for getting this ingested and then keeping the record updated?

I was using the l2ss-py as a reference, maybe this is a good template to follow for next steps? There is also this wiki page but it has not been updated since 2022.

@frankinspace
Copy link
Member Author

Yes, content looks good (noticed URL is missing one / after https).

The second AC on this issue is to wire it up to automatically update as part of the publication step during CICD. We can use the cmr-umm-updater github action that we wrote to do this https://github.com/podaac/cmr-umm-updater

This is how l2ss-py does it https://github.com/podaac/l2ss-py/blob/develop/.github/workflows/build-pipeline.yml#L167-L208

However, I did just notice a problem in that action that will need to be fixed prior to hooking up this automation: podaac/cmr-umm-updater#26

@nikki-t
Copy link
Collaborator

nikki-t commented Feb 27, 2024

I fixed the URL and updated the GitHub Action workflow to include a "Publish" step which publishes the UMM-S record if the build and docker steps completed successfully. This will allow us to test publication of the record without deploying to any of the AWS environments.

However, I ran into an issue when testing the GitHub Action. The log can be found here. The cmr-umm-updater returns the following error message: /entrypoint.sh: line 16: cmr/cmr.json: No such file or directory

@frankinspace - do you know what might be causing this error? I believe that I have the cmr directory with the appropriate UMM-S JSON in the correct place.

@frankinspace
Copy link
Member Author

@nikki-t it looks like in your action you are referring to the umm-json file as cmr/hydrocron_umm_s.json

umm-json: 'cmr/hydrocron_umm_s.json'

But the name of the file in the repo is actually cmr/cmr.json

https://github.com/podaac/hydrocron/blob/313ddec82e7ac918a1df10d53e0142135a16b00b/cmr/cmr.json

I would suggest renaming the file in the repo to hydrocron_umm_s.json

@nikki-t
Copy link
Collaborator

nikki-t commented Mar 1, 2024

I figured out the error I was encountering but it looks like the cmr-umm-updater GitHub Action only works for uat and ops environments.

 jq: error (at cmr/cmr.json:85): Cannot index string with string "URLValue"
INFO:root:Starting UMM-S update
INFO:root:native_id: POCLOUD_podaac_hydrocron
Traceback (most recent call last):
  File "/venv/bin/umms_updater", line 8, in <module>
    sys.exit(run())
  File "/venv/lib/python3.9/site-packages/podaac/umms_updater/umms_updater.py", line 298, in run
    main(_args)
  File "/venv/lib/python3.9/site-packages/podaac/umms_updater/umms_updater.py", line 218, in main
    concept_id = pull_concept_id(args.env, provider, native_id, args.timeout)
  File "/venv/lib/python3.9/site-packages/backoff/_sync.py", line 43, in retry
    ret = target(*args, **kwargs)
  File "/venv/lib/python3.9/site-packages/podaac/umms_updater/umms_updater.py", line 156, in pull_concept_id
    url_prefix = svc_update.cmr_environment_url(cmr_env)
  File "/venv/lib/python3.9/site-packages/podaac/umms_updater/util/svc_update.py", line 37, in cmr_environment_url
    raise Exception('CMR environment selection not recognized;'
Exception: CMR environment selection not recognized; Select uat or ops.

Does it make sense to hold off and only publish a UMM-S record for hydrocron UAT and OPS deployments? I can update the build.yml so that it is only triggered for those environments.

@frankinspace
Copy link
Member Author

ah, yes that is correct. No umm-s in SIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants