Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inconsistency for the /podcasts/bytag endpoint #98

Closed
pluto-dev opened this issue Apr 24, 2023 · 4 comments
Closed

Type inconsistency for the /podcasts/bytag endpoint #98

pluto-dev opened this issue Apr 24, 2023 · 4 comments

Comments

@pluto-dev
Copy link

I made the following comment on issue #39, but I don't know if people will see it on a closed issue, so I opened this one instead.

Hey, this issue still seems to exist for following API endpoint:

https://api.podcastindex.org/api/1.0/podcasts/bytag

There a bunch of feeds with "categories": [ ]

Originally posted by @pluto-dev in #39 (comment)

To be precise, the schema describes it as follows:

An array of categories, where the index is the Category ID and the value is the Category Name.

All Category numbers and names are returned by the categories/list endpoint.

The response we get from the API endpoint and the example both show that we receive an object, except when the collection is empty, in which case we receive and empty array. This is inconsistent with the schema's description, which states that we should receive an array of categories
As a result, we cannot rely on the API to provide us with accurate data regarding the /podcasts/bytag endpoint.

@daveajones
Copy link
Contributor

I’ll check it out.

@stevencrader
Copy link
Collaborator

They now seem to be returning null instead of []. Can you double check and let us know if it still happens and with which feed.

Thanks

@pluto-dev
Copy link
Author

They now seem to be returning null instead of []. Can you double check and let us know if it still happens and with which feed.

Thanks

Seems fine for me now. On 4843 objects i couldn't find any where categories is returning an array. 👍

@daveajones
Copy link
Contributor

Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants