Low memory file fetch #73
Conversation
this is usefull for minimal memory settings.
(This prevents explosion of open file handles on many requests.)
|
Hi there, Is anyone watching this? Daniel |
| * @throws PodioServerError | ||
| * @throws PodioUnavailableError | ||
| */ | ||
| public static function request($method, $url, $attributes = array(), $options = array(), $returnRawAsRescourceOnly = false) { |
There was a problem hiding this comment.
Can you get rid of the docstring as it's not related to the functionality you're adding. Also, use the $options arg for your new option instead of adding a new function argument
|
Sorry about that! I've added some comments to get the code style aligned for starters |
|
Hi @haugstrup , thanks for the feedback - I committed the changes you suggested. |
|
Thanks Daniel, I'll do a proper review sooner rather than later :) |
|
Hi @haugstrup , |
|
Hey @daniel-sc, awesome work and sorry for the late response. Could you rebase against the latest master please so I can merge? :) Cheers! |
Conflicts: models/PodioFile.php
|
Done. @haugstrup you can merge. |
|
Thanks! |
Hi,
the commits add the functionality to fetch files from podio without loading them into memory - this is very useful when handling large files.
Could you please review (and merge)?
cheers, Daniel