Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PdfFontConfigWrapper.cpp has #include <fontconfig/fontconfig.h> for undefined PODOFO_HAVE_FONTCONFIG #58

Closed
blackandwhitebg opened this issue Feb 24, 2023 · 1 comment
Closed

PdfFontConfigWrapper.cpp has #include <fontconfig/fontconfig.h> for undefined PODOFO_HAVE_FONTCONFIG #58

blackandwhitebg opened this issue Feb 24, 2023 · 1 comment

Comments

@blackandwhitebg
Copy link

I`ve been experimenting with different types of builds.

According to the documentation fontconfig is optional for Windows, but PdfFontConfigWrapper.cpp fails to compile because it includes its header, ignoring the fact that
podofo_config.h has /* #undef PODOFO_HAVE_FONTCONFIG */
@ceztko ceztko closed this as completed in d0dc4f6 Feb 24, 2023
@ceztko
Copy link
Contributor

ceztko commented Feb 24, 2023

Fixed, but please consider that fontconfig may be no more optional at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ceztko @blackandwhitebg