Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 1.12.10 to 1.12.17 is a breaking change. #146

Closed
ChillFish8 opened this issue Dec 30, 2021 · 2 comments
Closed

Upgrading from 1.12.10 to 1.12.17 is a breaking change. #146

ChillFish8 opened this issue Dec 30, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ChillFish8
Copy link

Expected Behavior

You expect when bumping the micro version from 10 to 17 that nothing breaks.

Actual Behavior

You previously merged APIs with Api1.combine(Api2).combine(Api3) however this has been removed in 1.12.17 it seems opting for the (more readable) (Api1, Api2, Api3) approach.

Steps to Reproduce the Problem

  1. Create an example API with poem 1.12.10 merging two Api's using the combine() method.
  2. Bump the micro version to 1.12.17
  3. Observe new compile errors.
@ChillFish8 ChillFish8 added the bug Something isn't working label Dec 30, 2021
@ChillFish8
Copy link
Author

Just as a note i'm aware that this was changed/removed in 1.12.11 however cargo will auto bump the version because it's 1.x and it's a micro version which was a bit un-expected.

@sunli829
Copy link
Collaborator

IDE can't recognize the combine method makes me unbearable. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants