Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing takeWhileInclusive, takeUntilInclusive, etc #33

Closed
mariacamenzuli opened this issue Feb 8, 2017 · 3 comments
Closed

Missing takeWhileInclusive, takeUntilInclusive, etc #33

mariacamenzuli opened this issue Feb 8, 2017 · 3 comments

Comments

@mariacamenzuli
Copy link
Contributor

I just came across a situation where I needed an inclusive version of takeWhile. This operator would take elements from a stream until but including the first element that does not match the given predicate.

It would be great if we could add takeWhileInclusive to the protonpack, along with inclusive versions of other operators like takeUntil, skipWhile, etc.
@poetix
Copy link
Owner

poetix commented Mar 7, 2017

That makes sense. It might be a while before I have time to do it myself - would you like to raise a pull request?

@mariacamenzuli
Copy link
Contributor Author

Yes I can.

@mariacamenzuli mariacamenzuli mentioned this issue Mar 12, 2017
Merged
@poetix
Copy link
Owner

poetix commented Mar 14, 2017

I've merged your changes and released a new 1.13 version, which should be available in Maven Central within the next 24 hours. Thanks for your contribution!

@poetix poetix closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@poetix @mariacamenzuli