Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Samsung devices #136

Closed
mmicoe opened this issue Sep 9, 2022 · 2 comments
Closed

Issue on Samsung devices #136

mmicoe opened this issue Sep 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@mmicoe
Copy link

mmicoe commented Sep 9, 2022

Issue using on some Samsung devices:
Using Godot 3.5
Admod Poing Studios 3.5

Issue on SmartPhone:
Device: Samsung Galaxy A52s 5G
Android: 12

If Admob is Enabled I get this issue:

2022-09-09 20:24:19.100 28440-28473/com.multiplicationworld E/AndroidRuntime: FATAL EXCEPTION: pool-4-thread-1
Process: com.multiplicationworld, PID: 28440
java.lang.IllegalArgumentException: com.multiplicationworld: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
at android.app.PendingIntent.checkFlags(PendingIntent.java:382)
at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:673)
at android.app.PendingIntent.getBroadcast(PendingIntent.java:660)
at androidx.work.impl.utils.ForceStopRunnable.getPendingIntent(ForceStopRunnable.java:174)
at androidx.work.impl.utils.ForceStopRunnable.isForceStopped(ForceStopRunnable.java:108)
at androidx.work.impl.utils.ForceStopRunnable.run(ForceStopRunnable.java:86)
at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:75)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
at java.lang.Thread.run(Thread.java:1012)

Additional context
The most curious thing is that I have tested it with an old Samsung tablet and it works fine.
Using Tablet Samsung SM-T580
Android: 8.1.0,
Admob works fine!

Please, what version of Admob can I use on Godot 3.5?

All the best!
Mauro

@mmicoe mmicoe added the bug Something isn't working label Sep 9, 2022
@mmicoe
Copy link
Author

mmicoe commented Sep 9, 2022

OK.
I readt he previous post:

Adding this line:

[dependencies]
remote=["com.google.android.gms:play-services-ads:21.1.0", "com.google.android.ump:user-messaging-platform:2.0.0"]

on Admob.gdap, it works fine!

Please, update the pluging!

All the best!
Thanks for your work!

@gumaciel
Copy link
Contributor

gumaciel commented Sep 9, 2022

Thank you for testing the implementation of #126, I will update the plugin and close the Issue!

@gumaciel gumaciel closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants