Banner isn't at the bottom of the screen on iPhone 12 Pro

[novalis]

Godot version

3.5.1

Plugin version

v2.1.1

Phone information

iPhone 12 Pro, ios 16

Issue description

The banner isn't at the bottom of the screen -- instead, it has crept up to cover my content.

Steps to reproduce

This seems to be true whether or not I have respect_safe_area turned on.

Additional context

No response

[gumaciel]

Thank you for opening this Issue, we will investigate this.

[gumaciel]

Seems to be working normally on Godot 3, i will generate some version of the plugins this days, but this bug really happened on Godot 4 and it's already be fixing

Without Respect Safe Area:

With Respect Safe Area:

Tested on :
Godot: 3.5.1-stable
Godot AdMob Editor: godot3-v1.3.3
Godot AdMob iOS: v2.1.2

[novalis]

I was using BOTTOM for position, not TOP.

[gumaciel]

@novalis this is actually working for me, it still happens to you on the latest version?

[novalis]

I'm sorry, but unfortunately, I don't know. I was testing using BrowserStack, since getting Godot working with the simulator on a M1 Mac is pretty annoying. But I gave up my BrowserStack account. I'm no longer working on the app in question, or any app that uses ads (for now). For what it's worth, the fix for me was:

diff --git a/plugin/admob/src/formats/Banner.mm b/plugin/admob/src/formats/Banner.mm
index 75e2a64..9f8cee1 100755
--- a/plugin/admob/src/formats/Banner.mm
+++ b/plugin/admob/src/formats/Banner.mm
@@ -150,6 +150,7 @@ - (void)addBannerViewToView {
                                         attribute:NSLayoutAttributeBottom
                                         multiplier:1
                                         constant:0]];
+       bannerView.center = CGPointMake(rootController.view.center.x, rootController.view.frame.size.height-CGSizeFromGADAdSize(GADAdSizeBanner).height/2);

[gumaciel]

Closing due stale, on #82 it should only appear the BannerAds in the SafeArea