Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLCs do not unlock #30

Closed
Com3Carne opened this issue Jun 9, 2022 · 8 comments
Closed

DLCs do not unlock #30

Com3Carne opened this issue Jun 9, 2022 · 8 comments
Assignees
Labels
Bug Something isn't working correctly.

Comments

@Com3Carne
Copy link

I don't know if it's a bug or not. But when I disable a DLC, it creates a SmokeAPI.json file with "unlock_all": false instead of true. Is this really supposed to happen or is it a real bug?

@Com3Carne Com3Carne added the Bug Something isn't working correctly. label Jun 9, 2022
@pointfeev
Copy link
Owner

Yes of course it's intended... if you disable a DLC you obviously don't want to unlock all of them?

@Com3Carne
Copy link
Author

Yes of course it's intended... if you disable a DLC you obviously don't want to unlock all of them?

But I'm disabling a specific DLC, not all.

@pointfeev
Copy link
Owner

The "unlock_all" option in SmokeAPI automatically unlocks all DLC possible regardless of the given app ids, thus if it's not ticked to false then that specific DLC you ticked off would still unlock. If you're curious, the purpose of providing app ids is as explained here.

@pointfeev
Copy link
Owner

Are you having issues with the unlocking of DLCs with how it's currently set up? I very well may have misinterpreted the descriptions of the JSON parameters.

@pointfeev
Copy link
Owner

Alright I've done some more testing with the case of unticking specific DLCs, and I've fixed a bunch of shit related to it. I'll have it pushed out as v3.5.1.0 soon, please do tell if it doesn't fix your issues. :)

@pointfeev pointfeev added the Waiting for Information Further information has been requested. label Jun 9, 2022
@Com3Carne
Copy link
Author

First of all, I want to say that the tool is great. Coming back to the subject, I think maybe the bug is from the SmokAPI. I was unchecking 1 DLC from RE2R, which would be the soundtrack DLC. It puts it as "unlock_all": false, and when opening the game, they just don't release anything. I had to edit it manually, changing it from false to true and the DLCs would work again.

@pointfeev
Copy link
Owner

I'd actually misinterpreted the parameters of SmokeAPI's configuration; I reworked it in v3.5.1.0, does that not fix it?

@Com3Carne
Copy link
Author

It's working perfectly. Thanks :)

@pointfeev pointfeev removed the Waiting for Information Further information has been requested. label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working correctly.
Projects
None yet
Development

No branches or pull requests

2 participants