New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for EnvironmentLess Stores #47
Comments
This is worth having a discussion about. Thanks @natemann! Early on we played with some helpers for
This is why all of the examples in the repo define struct environments, even if they don't have any dependencies. Of course, these are just the trade-offs we've currently landed at, and depending on how someone builds an application and how much they modularize, I can see some applications having a lot of small reducers with no dependencies at all benefitting from using One more helper is a reducer initializer that doesn't need to return
|
@stephencelis. I see your point. I was not really thinking about a reducer that does not have to return Secondly, I feel that we can still have an I know this is a little off topic, but your last comment intrigued me. My thoughts on |
Worth noting that you'll still want to introduce an environment to supply this work if you want to write tests for those actions. We have a few examples of these kinds of tests in the demo apps. Voice Memos, for one, has some fire-and-forget effects in its audio recorder and audio player dependencies.
Yup! I think those versions of |
@natemann We just got a Swift forum for discussions like this so that we can tighten the GitHub issues focus on bugs. Would you like to move the discussion there? |
Sure thing. |
Following along with creating Stateless and Actionless viewStores in #43 , what are the thoughts on extending
Store
andReducer
with functions whereEnvironment
is Void? I am finding that for most stores, I don't need anEnvironment
object.I think it would be nice to have, but could bloat TCA quite a bit as you would have extensions for 3 possible scenarios:
-GlobalEnvironment is void (for pullbacks)
The text was updated successfully, but these errors were encountered: