Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.3 is no longer dynamic? (my project breaks) #77

Closed
pcolton opened this issue May 12, 2020 · 2 comments
Closed

0.1.3 is no longer dynamic? (my project breaks) #77

pcolton opened this issue May 12, 2020 · 2 comments

Comments

@pcolton
Copy link

pcolton commented May 12, 2020

I just updated to 0.1.3 and my project won't compile any more:

Swift package product 'ComposableArchitecture' is linked as a static library by 'Library' and 5 other targets. This will result in duplication of library code.

I've been following the comments about changes required for testing, so is making the main package no longer dynamic part of that fix? It means I now have to wrap the package in a framework again, correct?

@stephencelis
Copy link
Member

@pcolton You're exactly right, sorry about that! We note the change in the second item of the release notes now here: https://github.com/pointfreeco/swift-composable-architecture/releases/tag/0.1.3

We're moving a bit more fast/loose with pre-1.0 releases but will try to keep these breakages to a minimum in the future.

@pcolton
Copy link
Author

pcolton commented May 12, 2020

No worries, just wanted to make sure before pushing my own fix.

@pcolton pcolton closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants