Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XcodeGen dependency as private #201

Closed
inamiy opened this issue Mar 26, 2019 · 4 comments
Closed

Change XcodeGen dependency as private #201

inamiy opened this issue Mar 26, 2019 · 4 comments

Comments

@inamiy
Copy link

inamiy commented Mar 26, 2019

Hi @pointfreeco team 馃憢

I just noticed that 1fb2e65 (adding XcodeGen dependency) leads end-users to also pull all of its unused dependency, and it is quite painful to me.

I don't think Swift Package Manager provides a clever way of separating it as a private dependency (e.g. like Carthage using Cartfile.private), but I would like to have at least environment variable switching to work around.

e.g. Example code can be found in Quick.
https://github.com/Quick/Quick/blob/a0e1457029c2a451a321fdd3a6a6f36ac367010f/Package.swift

@stephencelis
Copy link
Member

@inamiy That's really clever! We hadn't considered scoping development dependencies in that fashion, but it makes perfect sense. We've been using XcodeGen all over in order to support Carthage, and locking to a specific XcodeGen version with Package.swift was very helpful, but we'd love to scope its use to an environment variable. Will look into this soon!

@inamiy
Copy link
Author

inamiy commented Mar 26, 2019

@stephencelis Good to hear! I will wait for your update 馃槃

@stephencelis
Copy link
Member

@inamiy Did a quick test and it works great: pointfreeco/swift-tagged@77bdcc1

We'll update all our repos soon accordingly!

@stephencelis
Copy link
Member

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants