Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch diffing algorithm to use patience #95

Closed
stephencelis opened this issue Nov 15, 2018 · 5 comments
Closed

Switch diffing algorithm to use patience #95

stephencelis opened this issue Nov 15, 2018 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@stephencelis
Copy link
Member

Patience is more human-readable.

@mbrandonw mbrandonw added the enhancement New feature or request label Dec 4, 2018
@stephencelis stephencelis added the help wanted Extra attention is needed label Dec 16, 2018
@digoreis
Copy link

Hi guys, I'm starting to try to implement this algorithm in Swift. The result is human-readable but the algorithm isn't readable 😄 . Is open yet this issue?

@stephencelis
Copy link
Member Author

Definitely open to start tracking in a PR if you'd like to submit one! We can all try cleaning up the code together.

@digoreis
Copy link

Ah ok, I will try to finish the patience implementation this week and transform in a Diff strategy.

I'm using this article: https://blog.jcoglan.com/2017/09/28/implementing-patience-diff/

My implementation V1: https://gist.github.com/digoreis/9254a292b3da2e97eb75f0afc3b384ef

@stephencelis
Copy link
Member Author

This looks like a great start! Would you be interested in opening a PR to incorporate it into SnapshotTesting so that we can try it out?

@stephencelis
Copy link
Member Author

Hi @digoreis! Just wanted to follow up here. I'm going to close this issue but would still love to see a PR in the future if you decide to take it on 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants