-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch diffing algorithm to use patience #95
Comments
Hi guys, I'm starting to try to implement this algorithm in Swift. The result is human-readable but the algorithm isn't readable 😄 . Is open yet this issue? |
Definitely open to start tracking in a PR if you'd like to submit one! We can all try cleaning up the code together. |
Ah ok, I will try to finish the patience implementation this week and transform in a Diff strategy. I'm using this article: https://blog.jcoglan.com/2017/09/28/implementing-patience-diff/ My implementation V1: https://gist.github.com/digoreis/9254a292b3da2e97eb75f0afc3b384ef |
This looks like a great start! Would you be interested in opening a PR to incorporate it into SnapshotTesting so that we can try it out? |
Hi @digoreis! Just wanted to follow up here. I'm going to close this issue but would still love to see a PR in the future if you decide to take it on 😄 |
Patience is more human-readable.
The text was updated successfully, but these errors were encountered: