Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

calculateBoundingBox in PolygonPoints.py #139

Open
Misca1234 opened this issue Jun 23, 2018 · 1 comment
Open

calculateBoundingBox in PolygonPoints.py #139

Misca1234 opened this issue Jun 23, 2018 · 1 comment
Labels

Comments

@Misca1234
Copy link
Contributor

    def calculateBoundingBox(self):
        min = max = self.getRealPosition(self.nodes[0])

Is this correct, does not min and max become the same object,
and therefroe the min and max functions update "both" objects at the same time

should it not be?

    def calculateBoundingBox(self):
        min = self.getRealPosition(self.nodes[0])
        max = self.getRealPosition(self.nodes[0])
@pointhi
Copy link
Owner

pointhi commented Jul 14, 2018

There is a more fundamental problem in this code. The getRealPosition method does not exist in this class, because it does not inherit from Node.

@pointhi pointhi added the bug label Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants