Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check_model_pars() returns derived #62

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat: check_model_pars() returns derived #62

merged 1 commit into from
Sep 29, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Sep 29, 2023

For compatibility with tmbr.

joethorley
joethorley approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures tmbr and smbr pass tests but once resolve derived parameter handling in these two packages it may be turned off again.

@krlmlr krlmlr changed the title check_model_pars() returns derived feat: check_model_pars() returns derived Sep 29, 2023
@krlmlr krlmlr merged commit a6c5de4 into main Sep 29, 2023
6 of 7 checks passed
@krlmlr krlmlr deleted the b-check-return-derived branch September 29, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joethorley joethorley joethorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlmlr @joethorley