Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement "pmb_code" class to support a strict subset of the nimble language #64

Merged
merged 16 commits into from
Oct 1, 2023
Merged

feat: Implement "pmb_code" class to support a strict subset of the nimble language #64

merged 16 commits into from
Oct 1, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Sep 29, 2023 •
edited

New methods from the (now archived) pmbr package are inlined here.

@krlmlr krlmlr force-pushed the pmbr branch 2 times, most recently from 95d9cea to 6ff0aac Compare October 1, 2023 11:02
@krlmlr krlmlr changed the title WIP: Support for pmbr WIP: Implement pmbr Oct 1, 2023
@krlmlr krlmlr changed the title WIP: Implement pmbr Implement pmbr Oct 1, 2023
@krlmlr krlmlr requested a review from joethorley October 1, 2023 13:05
joethorley
joethorley approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

@krlmlr krlmlr mentioned this pull request Oct 1, 2023
Merged
joethorley
joethorley approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 1, 2023

Can you please try a few of your or your team's recent analyses with this version? These should work out of the box, except that you now need model(code = "...") instead of model("...") to avoid deprecation warnings. You can pak::pak("poissonconsulting/poispkgs@pmbr6", ask = FALSE) to get it, or just install this branch. (The branches for the jmbr and tmbr packages are needed only to fix tests.)

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 1, 2023

  • Should it be engine = "jmbr" or "rjags"? I suspect the latter would be more natural.
  • One thing we're not doing yet: check for the presence of ^ -2 or 1 / in the sd term. I can add that.

@joethorley
Copy link
Member

I'm thinking it should be engine = "jags"

@joethorley
Copy link
Member

I just ran on a jags and stan analysis and it worked perfectly

@joethorley
Copy link
Member

also on TMB

@krlmlr krlmlr changed the title Implement pmbr feat: Implement "pmb_code" class to support a strict subset of the nimble language Oct 1, 2023
@krlmlr krlmlr merged commit 524248a into main Oct 1, 2023
7 checks passed
@krlmlr krlmlr deleted the pmbr branch October 1, 2023 18:45
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joethorley joethorley joethorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlmlr @joethorley