Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Propose to convert to PackedScene with mesh instance, 2d mesh and 2d vgpath #4

Closed
fire opened this issue Feb 29, 2020 · 6 comments
Closed

Comments

@fire
Copy link

fire commented Feb 29, 2020

I propose to convert to three types: 3d scene with mesh instances, 2d scene with vgpath and 2d scene with meshinstance2d.

Currently did the mostly complicated scheme which is the 3d mesh.

Any comments?

Here are some videos.

image

image

https://cdn.discordapp.com/attachments/659280732673409024/683252767787450368/2020-02-29_01-53-46.mp4

https://upload.wikimedia.org/wikipedia/commons/f/fd/Ghostscript_Tiger.svg

Will post a branch / pr for review.

I'm looking for advice and design suggestion for reducing the draw calls for the tiger.

@fire fire changed the title Propose to convert to PackedScene with mesh instance, 2d mesh and 2d vpath Propose to convert to PackedScene with mesh instance, 2d mesh and 2d vgpath Feb 29, 2020
@fire
Copy link
Author

fire commented Feb 29, 2020

@fire
Copy link
Author

fire commented Feb 29, 2020

I got stuck. Somewhere in this code causes the vgpath to not refresh correctly, but it works if I move the entire vgpath.

image

Edited: Transparent area -> Orange

@fire
Copy link
Author

fire commented Mar 8, 2020

I resolved an issue with colors not showing.

SRGB colours must be match, normals and tangents must be generated.

Sidenote: I broke gradients. Not sure where to start to debug.

@Jeremi360
Copy link

Can I use this in godot 3.2?

@fire
Copy link
Author

fire commented Mar 16, 2020

@jebedaia360 This branch doesn't correctly port the gradients, but it's on the 3.2 branch.

I recommend using godotengine/godot#36922.

@poke1024 Can you take a look at my code to understand why gradients are broken? Or at least explain how they work?

@fire
Copy link
Author

fire commented Aug 8, 2020

I decided to focus on vgpath and animations. https://github.com/godot-extended-libraries/lottie

https://airbnb.design/lottie/

@fire fire closed this as completed Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants