Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "enclosing <symbol>" transformation #14

Closed
pokey opened this issue Jun 23, 2021 · 4 comments · Fixed by #324
Closed

Support "enclosing <symbol>" transformation #14

pokey opened this issue Jun 23, 2021 · 4 comments · Fixed by #324
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jun 23, 2021

We'd like to support transformations such as "outer round" to take everything inside and including the parentheses containing a token, as well as "inner round", "inner square", etc.

Would also be nice to support selecting the delimiter symbols themselves, eg the open and close paren. This could be eg "border round", "border square", etc. Or "disc", or "doughnut", or "bound" or something. This version of the transformation would be useful when combined with a list-based "replace with" command, so could say eg "replace border round with square" to change enclosing parens to square brackets.

@pokey pokey added the enhancement New feature or request label Jun 23, 2021
@pokey
Copy link
Member Author

pokey commented Jun 26, 2021

Any thoughts on term for selecting the delimiter symbols themselves? Considering:

  • "boundary"
  • "bound"
  • "border"
  • "doughnut"
  • "disc"
  • "edge"
  • "flank"
  • "hedge"
  • "fringe"

cc/ @brxck @AndreasArvidsson

@brxck
Copy link
Collaborator

brxck commented Jun 26, 2021

"bound" would be my vote.

@pokey
Copy link
Member Author

pokey commented Jun 26, 2021

Yeah I like "bound" too. Will need to see if it conflicts with "round" in practice

@AndreasArvidsson
Copy link
Member

Bound sounds good

@pokey pokey added this to To do in Cursorless engine 2.0 via automation Jul 9, 2021
@pokey pokey mentioned this issue Nov 26, 2021
30 tasks
@pokey pokey moved this from To do to Done in Cursorless engine 2.0 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants