Add new hats and preprocessing script #277
Conversation
pokey
force-pushed
the
pokey-icon-alignment
branch
from
df4e5fd
to
5cea580
Compare
package.json
Outdated
| "fourPointStar": false, | ||
| "chevron": false, |
There was a problem hiding this comment.
Turning these off by default
| @@ -0,0 +1,35 @@ | |||
| # Contributing | |||
There was a problem hiding this comment.
Moving contributing info to its own file
| @@ -0,0 +1,32 @@ | |||
| import * as parser from "fast-xml-parser"; | |||
There was a problem hiding this comment.
Got tired of doing this stuff manually
|
Now that our SVGs actually have padding on top and bottom we should definitely normalize on height |
pokey
force-pushed
the
pokey-icon-alignment
branch
from
dae8c0d
to
615f4ce
Compare
pokey
force-pushed
the
pokey-icon-alignment
branch
from
94d7e1c
to
fae21bd
Compare
| @@ -228,13 +228,13 @@ | |||
| "description": "Which shapes to enable", | |||
| "type": "object", | |||
| "properties": { | |||
| "fourPointStar": { | |||
| "ex": { | |||
There was a problem hiding this comment.
Changing these to make them easier to remember
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "cursorless.individualHatAdjustments": { | ||
| "description": "Separate adjustments for each hat shape", | ||
| "type": "object", | ||
| "default": {} | ||
| "default": { |
There was a problem hiding this comment.
Put a default value in to make this one easier to use when tweaking. Tempted to remove this stuff but it is super useful
| ((originalViewBoxWidth / hatWidthToCharacterWidthRatio) * svgWidthPx) / | ||
| characterWidth; | ||
| const newViewBoxHeight = (newViewBoxWidth * svgHeightPx) / svgWidthPx; | ||
| const newViewBoxWidth = originalViewBoxWidth * (svgWidthPx / hatWidthPx); |
There was a problem hiding this comment.
This one simplified nicely
src/scripts/addHatAdjustments.ts
Outdated
| @@ -0,0 +1,53 @@ | |||
| /** | |||
There was a problem hiding this comment.
Got tired of doing this one manually as well
pokey
force-pushed
the
pokey-icon-alignment
branch
from
05dde4e
to
9e1005b
Compare
pokey
requested review from
AndreasArvidsson
and removed request for
AndreasArvidsson
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 377.73 272.77" width="0.7em" height="0.7em"><defs><style>.cls-1{fill:black;}</style></defs><g id="Layer_2" data-name="Layer 2"><g id="Layer_1-2" data-name="Layer 1"><path class="cls-1" d="M377.73,48V0s-84.23,168.46-125,162.43c-31.64-4.68-113.06-108.7-113.06-108.7L6,214.53,0,272.77S99.58,118.5,141,126.22C171.82,132,262,242.79,262,242.79Z"/></g></g></svg> | |||
There was a problem hiding this comment.
This one could use a little tweaking, but I think it's good enough to ship for now
src/core/exposeEnablements.ts
Outdated
| @@ -0,0 +1,51 @@ | |||
| import { join } from "path"; | |||
There was a problem hiding this comment.
@AndreasArvidsson Ok I switched to exposing state via file. Just copied some basic stuff from command server; should be fairly robust
The above screenshots are with SF Mono and the following configuration:
{ "cursorless.hatSizeAdjustment": 20, "cursorless.hatVerticalOffset": 5 }Closes #269
ex=>x?star=>crossbolta little prettierframeandholeto make them easier to tell apartwingex: reduce widthcurve: use flipped fox without pointyellow: darken on light modegray: tweak on light modeeye: slightly wider pupilframe: with a bit more paintwing: potentially raise center without changing location of points