Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Explanation in polars.Expr.dt.timestamp #15275

Closed
Ebraheem1 opened this issue Mar 25, 2024 · 1 comment · Fixed by #15281
Closed

Incorrect Explanation in polars.Expr.dt.timestamp #15275

Ebraheem1 opened this issue Mar 25, 2024 · 1 comment · Fixed by #15281
Labels
accepted Ready for implementation documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Ebraheem1
Copy link

https://github.com/pola-rs/polars/blame/ec8f5e3a414c857a65bbb3db83720275282b14b4/py-polars/polars/expr/datetime.py#L1419-L1451

Here you show that the default value should be microseconds us, however, in the example you use the default as ns.
@Ebraheem1 Ebraheem1 changed the title Incorrect Explanation Incorrect Explanation in polars.Expr.dt.timestamp Mar 25, 2024
@MarcoGorelli MarcoGorelli added documentation Improvements or additions to documentation good first issue Good for newcomers accepted Ready for implementation labels Mar 25, 2024
@mcrumiller mcrumiller mentioned this issue Mar 25, 2024
Merged
@mcrumiller
Copy link
Contributor

Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted Ready for implementation documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(python): Fix time unit in timestamp example mcrumiller/polars
3 participants
@mcrumiller @Ebraheem1 @MarcoGorelli