Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow search_sorted directly on multiple chunks, and fix behavior around nulls #16447

Merged
merged 4 commits into from
May 24, 2024
Merged

fix: allow search_sorted directly on multiple chunks, and fix behavior around nulls #16447

merged 4 commits into from
May 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented May 23, 2024 •
edited

Closes #16420.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 23, 2024
@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited

Codecov Report

Attention: Patch coverage is 91.27517% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.45%. Comparing base (462bc8b) to head (4355642).
Report is 11 commits behind head on main.

Files Patch % Lines
...polars-core/src/chunked_array/ops/search_sorted.rs 90.57% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16447      +/-   ##
==========================================
+ Coverage   81.43%   81.45%   +0.01%     
==========================================
  Files        1409     1409              
  Lines      184678   184730      +52     
  Branches     2971     2971              
==========================================
+ Hits       150396   150475      +79     
+ Misses      33762    33735      -27     
  Partials      520      520

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

@orlp can you do a doctest run?

@orlp
Copy link
Collaborator Author

orlp commented May 24, 2024

@ritchie46 That test failure isn't really a failure, the default behavior is "any", and I just changed the default behavior of any to be equivalent to "left" (which is a valid return value for any). I'll update that test.

@ritchie46 ritchie46 merged commit d4c3aba into pola-rs:main May 24, 2024
27 checks passed
@orlp orlp mentioned this pull request May 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search_sorted in an order of magnitude slower when single element chunk vstacked to the original dataframe
2 participants
@orlp @ritchie46