Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for TPCH 22 SQL Queries #16659

Open
djouallah opened this issue Jun 2, 2024 · 3 comments
Open

Full support for TPCH 22 SQL Queries #16659

djouallah opened this issue Jun 2, 2024 · 3 comments
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature

Comments

@djouallah
Copy link

Description

it will be nice if polars support running all the 22 TPCH SQL Queries unmodified, so far only 1 and 6 seems to be working
https://colab.research.google.com/drive/17vaCF-3QSe0bGv0YOCeCWyq7yGpKxRmV#scrollTo=kFQ0KCKYfMCx

@djouallah djouallah added the enhancement New feature or an improvement of an existing feature label Jun 2, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Jun 2, 2024
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Jun 2, 2024

That actually sounds like a good driver for feature prioritisation on the SQL interface (which is by no means complete yet - lots done, lots to do ;) 👌

Also, can I check which version of Polars you tested on? The latest (0.20.31) has quite a number of updates that may help.

Looks like adding support for implicit JOIN syntax would also immediately raise the number of supported queries; I'll investigate.

@djouallah
Copy link
Author

actually you are right, I changed the syntax to use joins and now we have 8 working from 22

https://colab.research.google.com/drive/10GUzHfrOSu1GHXoY7stQ22_xITNkmnVs#scrollTo=LjOA0sqjFYRc
image

@djouallah
Copy link
Author

I am not too worry about the sql syntax, I am sure it will be added eventually, what will really nice is to have support for ctx.sql("select 42").show() so i don't have to create a separate function just for polars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants