-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize references to "null" in methods #17272
Comments
We will rename Also for |
different opinion here! imo we should drop the "s" for all cases Reasons
|
Not sure.
I have considered this, but you conveniently gloss over the fact that
An expression doesn't have any rows, so For what it's worth, personally I feel like Anyway, I'll sleep on this one before merging it, but I'm not convinced at all by your arguments here. |
I personally prefer the singular form as well. These functions drop/fill or check the existence of any null value so it makes sense to remove the s. Moreover, I think the fill_null is much more used than drop_nulls and has_nulls, so it will break less code. |
Thinking about this a bit more the best solution imo would be actually be to completely remove Thoughts? 💭 |
Also prefer singular |
Not sure about |
After some thought I agree with @JulianCologne. I was thinking about this yesterday and I think we should ask if it is a single row/elementwise question and if so go for singular.
I want to put this on a hold as I don't think this merits a change at all. |
Agree. Status quo is fine, I think. I'll close this for now. |
Description
This is kind of nitpicking, but I can't tell you how many times I have had to rerun cells because of this. In the current version of Polars, the method to drop null values is called drop_nulls, while the method to fill null values is called fill_null (no s).
Can we please rename this? Either both plural or both singular.
The text was updated successfully, but these errors were encountered: