Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should nodejs-polars remain in polars? #4148

Closed
universalmind303 opened this issue Jul 25, 2022 · 5 comments
Closed

Should nodejs-polars remain in polars? #4148

universalmind303 opened this issue Jul 25, 2022 · 5 comments

Comments

@universalmind303
Copy link
Collaborator

Just wondering if nodejs-polars should remain in the main polars project, or if it should be moved to it's own repo.

99% of the PR's are for python or rust, and a lot of these add breaking changes that need to be updated in JS too. Most people don't use the JS bindings, so it makes sense that it isnt being updated, but this causes the JS bindings to regularly fall out of sync with the other two. Being the primary contributor, it is becoming more difficult to keep the JS bindings up to date.

After nearly 8 months, the JS bindings are still rarely used: ~500 downloads a month.

@universalmind303 universalmind303 changed the title Should nodejs-polars remain in polars? Should nodejs-polars remain in polars? Jul 25, 2022
@ritchie46
Copy link
Member

I can understand it puts a strain on your time and makes it harder to work in your ideal pace. I think it could be transferred to a separate repository.

If we then rely on the released crates.io version, the pace will be a lot lower.

@slonik-az
Copy link
Contributor

slonik-az commented Jul 25, 2022

If we then rely on the released crates.io version, the pace will be a lot lower.

Since we are at this topic, would it be possible to keep the polars releases consistent across crates.io and github ?

Currently, the polars versions are as follows:

  • on crates.io it is version 0.22.8,
  • polars/Cargo.toml on master branch says "0.22.6"
  • github's latest release 0.22.1

Unnecessary inconsistent 😄

@universalmind303
Copy link
Collaborator Author

I think it could be transferred to a separate repository.

makes sense to me.
@ritchie46 if it's okay with you, i'd like to still keep it in the pola-rs org. pola-rs/nodejs-polars.
If you prefer not to though, I can just as easily move it into my own repo.

@ritchie46
Copy link
Member

@ritchie46 if it's okay with you, i'd like to still keep it in the pola-rs org. pola-rs/nodejs-polars.

Yes, I agree. You are doing awesome work and it stays true to the polars project, so I think it can be under the polars umbrella. I am currently on vacation, but I shall open a new repo during or after.

@universalmind303
Copy link
Collaborator Author

I'm wondering, should we keep the two linked via a git submodule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants