refactor: swap pl$Series and as_polars_series.default
#1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
commented
Apr 6, 2024
| @@ -367,13 +369,15 @@ as_polars_series.POSIXlt = function(x, name = NULL, ...) { | |||
| #' @rdname as_polars_series | |||
| #' @export | |||
| as_polars_series.data.frame = function(x, name = NULL, ...) { | |||
| pl$DataFrame(unclass(x))$to_struct(name = name) | |||
| as_polars_df(x)$to_struct(name = name) | |||
There was a problem hiding this comment.
This change is not directly related, but is a small refactoring to make object conversions more appropriate.
Comment on lines
+378
to
+380
| as_polars_series.vctrs_rcrd = function(x, name = NULL, ...) { | ||
| pl$select(unclass(x))$to_struct(name = name) | ||
| } |
etiennebacher
approved these changes
Apr 6, 2024
Comment on lines
+306
to
+307
| #' [as_polars_series()] is a generic function that converts an R object to | ||
| #' [a polars Series][Series_class]. |
There was a problem hiding this comment.
Should we have a list of R objects that can be converted to Series?
There was a problem hiding this comment.
Definitely needed... See #425.
The documentation for the arrow package is helpful.
There was a problem hiding this comment.
Ok, we can address #425 in full in another PR then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1012.
as_polars_series.default()used to callpl$Series(), but will be changed so thatpl$Series()callsas_polars_series().This will ensure that every object is properly converted to a Series with
pl$Series().Python's
polars.Series.__init__()internally converts various objects into a Series through a large number of conditional branches. This update is very similar to that.