Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: <DataFrame>$write_ipc() and update the argument name of <LazyFrame>$scan_ipc() #1032

Merged
merged 10 commits into from
Apr 13, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Apr 13, 2024

During testing, I found that the argument name displayed in the warning thrown by pl$scan_ipc() when the Arrow file is compressed is not memmap but memory_map and the argument name needs to be updated.

@eitsupi eitsupi changed the title feat: <DataFrame>$write_ipc() feat!: <DataFrame>$write_ipc() and update the argument name of <LazyFrame>$scan_ipc() Apr 13, 2024
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

NEWS.md Outdated Show resolved Hide resolved
@etiennebacher etiennebacher merged commit 54feba1 into main Apr 13, 2024
22 checks passed
@etiennebacher etiennebacher deleted the write-ipc branch April 13, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants