Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store URLs in environment to avoid issues with long filenames #1049

Merged
merged 12 commits into from
Apr 23, 2024
Merged

fix: store URLs in environment to avoid issues with long filenames #1049

merged 12 commits into from
Apr 23, 2024

Conversation

DyfanJones
Copy link
Contributor

Fixes #1046

eitsupi
eitsupi requested changes Apr 18, 2024
View reviewed changes
R/io_csv.R Outdated Show resolved Hide resolved
tests/testthat/test-csv-read.R Outdated Show resolved Hide resolved
etiennebacher
etiennebacher reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DyfanJones, can you also add a bullet point in NEWS in a "Bug fixes" category?

tests/testthat/test-csv-read.R Outdated Show resolved Hide resolved
R/io_csv.R Outdated Show resolved Hide resolved
etiennebacher
etiennebacher requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just have a couple of minor comments and the conflict needs to be resolved, but after that I'm ok to merge

NEWS.md Outdated Show resolved Hide resolved
R/io_csv.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher changed the title Cache temp file fix: store URLs in environment to avoid issues with long filenames on Windows Apr 23, 2024
@DyfanJones @etiennebacher
remove white space
83bf470 
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@etiennebacher etiennebacher changed the title fix: store URLs in environment to avoid issues with long filenames on Windows fix: store URLs in environment to avoid issues with long filenames Apr 23, 2024
etiennebacher
etiennebacher approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher
Copy link
Collaborator

@eitsupi your approval is required to merge

eitsupi
eitsupi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi merged commit 5754d06 into pola-rs:main Apr 23, 2024
17 of 19 checks passed
@etiennebacher etiennebacher mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with reading from long urls
3 participants
@DyfanJones @etiennebacher @eitsupi