Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lazy functions #196

Merged
merged 12 commits into from
May 12, 2023
Merged

More lazy functions #196

merged 12 commits into from
May 12, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented May 4, 2023

  • add missing lazy functions to pl$...
  • rename functions_x files to match py-polars
  • deprecate $list()
  • add n_unique, approx_n_unique, head, tail

@sorhawell
Copy link
Collaborator Author

remainder not implement plus some priortization 3 higher

3#map
3#apply
3#fold
3#reduce
3#cumfold
3#cumreduce
3#exclude
3#groups
3#format

2#cumsum
2#any
2#all cover bitwise also
2#quantile
2#arange
2#pl$collect_all
2# pl$repeat
2#pl$arg_where

1#spearman_rank_corr
1#pearson_corr
1#corr
1#cov
1#arg_sort_by
1#duration
1#datetime_
1#date_
1#concat_str_
1#pl$from_epoch
1#pl$rolling_cov
1#pl$rolling_corr

Merge remote-tracking branch 'origin/main' into more_lazy_functions

# Conflicts:
#	man/pl_pl.Rd
#' df$select(pl$head("a",2))
#'
#' pl$head(df$get_column("a"),2)
pl$head = function(column = NULL, n = 10) {#-> Expr | Any:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NULL is not an acceptable input, then we may want to leave the argument without default and include an is.missing() check instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups good catch :)

@vincentarelbundock
Copy link
Collaborator

remainder not implement plus some priortization 3 higher

I'm likely have time to look at some of these next week if you are willing to wait. I can open a separate PR.

@sorhawell sorhawell mentioned this pull request May 10, 2023
29 tasks
@sorhawell
Copy link
Collaborator Author

I'm likely have time to look at some of these next week if you are willing to wait. I can open a separate PR.

Cool @vincentarelbundock :), I made a task list in #204. You can reserve any you want, but it would anyways be unlikely I would get to finish them all by next week.
I will also wrap up this PR and start a new one.

@sorhawell sorhawell marked this pull request as ready for review May 10, 2023 12:14
@sorhawell sorhawell changed the title WIP: More lazy functions More lazy functions May 10, 2023
R/functions__lazy.R Outdated Show resolved Hide resolved
R/functions__lazy.R Show resolved Hide resolved
R/functions__lazy.R Show resolved Hide resolved
R/functions__lazy.R Outdated Show resolved Hide resolved
R/functions__lazy.R Outdated Show resolved Hide resolved
R/functions__lazy.R Show resolved Hide resolved
R/series__series.R Outdated Show resolved Hide resolved
R/series__series.R Outdated Show resolved Hide resolved
R/expr__expr.R Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
sorhawell and others added 3 commits May 12, 2023 10:11
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@etiennebacher etiennebacher merged commit 1650738 into main May 12, 2023
8 checks passed
@etiennebacher etiennebacher deleted the more_lazy_functions branch May 12, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants