Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point to rpolars/extendr branch pr473_553_555_566 #252

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Jun 22, 2023

This PR will adopt the current state of extendr PRs
extendr/extendr#473 - allow returning rust result to R
extendr/extendr#553 - allow renaming extendr struct on R side only
extendr/extendr#555 - fix memory leak
extendr/extendr#566 - escape % to avoid trigger formatting with Rprintf. #258

r-polars already adopted a previous state of PR473

Merge branch 'main' into adopt_extendr_pr473_553_555

# Conflicts:
#	R/extendr-wrappers.R
@sorhawell sorhawell mentioned this pull request Jun 26, 2023
@sorhawell sorhawell changed the title point to rpolars/extendr branch pr473_553_555 point to rpolars/extendr branch pr473_553_555_566 Jun 26, 2023
@sorhawell sorhawell marked this pull request as ready for review June 26, 2023 10:12
@sorhawell sorhawell requested a review from eitsupi June 26, 2023 12:41
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working to improve extendr!

@eitsupi eitsupi merged commit b9f1c4a into main Jun 29, 2023
8 checks passed
@eitsupi eitsupi deleted the adopt_extendr_pr473_553_555 branch June 29, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants