-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add polars_info
function
#271
Conversation
good idea the py-polars equivalent >>> pl.show_versions()
--------Version info---------
Polars: 0.18.4
Index type: UInt32
Platform: macOS-12.6.6-x86_64-i386-64bit
Python: 3.10.9 (main, Dec 15 2022, 18:18:30) [Clang 14.0.0 (clang-1400.0.29.202)]
----Optional dependencies----
numpy: 1.24.3
pandas: <not installed>
pyarrow: 12.0.0
connectorx: <not installed>
deltalake: <not installed>
fsspec: <not installed>
matplotlib: <not installed>
xlsx2csv: <not installed>
xlsxwriter: <not installed>
>>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add a snapshot test?
cat("\n") | ||
} | ||
|
||
cat("R Polars package version: ", format(x$version), "\n\n", sep = "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to have the rust-polars version as well? (and does it make sense to display it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
But we uses unreleased version of rust-polars here, so I think showing rust-polars' version make little sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further investigation, it seems that there is no constant in rust-polars to display the version.
So I think we need to update rust-polars first to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened an issue about that. pola-rs/polars#9659
I was hesitant to add a snapshot test, given that results can vary depending on build conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @eitsupi
Sorry, I may have made a mistake on something....... polars_info()
#> R Polars package version: 0.6.1.9000
#>
#> Features:
#> simd FALSE
#> |
Now I understand why. I had misunderstood the use of target_feature. I should use |
Based on #262, close #269
Implement a function like
arrow::arrow_info()
It provides fairly limited information for now, but other information can be added in the future.