Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the contents of Cargo.toml #300

Closed
eitsupi opened this issue Jul 4, 2023 · 2 comments · Fixed by #800
Closed

Revise the contents of Cargo.toml #300

eitsupi opened this issue Jul 4, 2023 · 2 comments · Fixed by #800
Assignees
Labels
enhancement New feature or request installation About installation or setup

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented Jul 4, 2023

Looking at rust-polars and python-polars, the features that require the nightly toolchain are named nightly.

https://github.com/pola-rs/polars/blob/126aef55c4909021176aad2cbb190f5a8daf731c/py-polars/Cargo.toml#L48
https://github.com/pola-rs/polars/blob/126aef55c4909021176aad2cbb190f5a8daf731c/polars/Cargo.toml#L17

Since we are now directly controlling the enabling and disabling of the simd feature here, it would be better to rewrite it to use nightly feature for consistency.

@eitsupi eitsupi added enhancement New feature or request installation About installation or setup labels Jul 4, 2023
@etiennebacher
Copy link
Collaborator

@eitsupi is this still an issue?

@eitsupi
Copy link
Collaborator Author

eitsupi commented Nov 11, 2023

Yes, I still want to work on this. I mean, we currently use a feature named full_features, which is realistically "nightly".

[features]
default = []
full_features = ["simd", "sql"]
simd = ["polars/simd"]
sql = ["polars/sql"]
rpolars_debug_print = []

I would like to keep full_features as a means to adjust MSRV for CRAN submissions and create nightly under it.
(For example, as of 0.10.0, it seems that it is polars/lazy that raises the MSRV from 1.71 to 1.73, so a possible response would be to add polars/lazy to full_features)

[features]
default = []                        # MSRV is 1.71
full_features = ["nightly", "lazy"] # Needs nightly toolchain
lazy = ["polars/lazy"]              # MSRV is 1.73
nightly = ["simd", "sql"]           # Needs nightly toolchain
simd = ["polars/simd"]              # Needs nightly toolchain
sql = ["polars/sql"]                # Needs nightly toolchain

(Of course, realistically this is not done because too much depends on polars/lazy. This is just an example.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installation About installation or setup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants