-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename functions to read CSV #305
Conversation
Thank you for working on this! I thought we should do this too, but when I looked at the py-polars implementation I realized that Python's That is, Python's |
actually py-polars uses also LazyCsvReader via here and via here I have no idea what the difference between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! I think it is a good change for consistency.
Perhaps we can merge this since it seems to have passed the test?
Oh, sorry. I must have misread the code....... |
Co-authored-by: sorhawell <sorhawell@gmail.com> Co-authored-by: eitsupi <ts1s1andn@gmail.com>
Mentioned in #267 (comment)
This PR:
lazy_csv_reader
->scan_csv
csv_reader
->read_csv
For now, they only can be accessed with
pl$
because I removedread_csv_
, but if we still want to have this kind of high-level helper, we should rename it (mayberead_csv_pl()
?)Feel free to push directly here