Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eitsupi as co-author #307

Closed
sorhawell opened this issue Jul 4, 2023 · 4 comments
Closed

Eitsupi as co-author #307

sorhawell opened this issue Jul 4, 2023 · 4 comments

Comments

@sorhawell
Copy link
Collaborator

sorhawell commented Jul 4, 2023

Dear admins
@etiennebacher @grantmcdermott @eitsupi 馃巶 馃帀 馃殌
( CC @vincentarelbundock )

Measured on various variables such as commits and code-lines @eitsupi has contributed >15% . Also there are several aspects of the polars package, where eitsupi is clearly the expert.

For these reasons I argue eitsupi should be added as co-author in DESCRIPTION. If we agree, as above could be the thumb rule for future co-authorship.

@sorhawell sorhawell mentioned this issue Jul 4, 2023
@eitsupi
Copy link
Collaborator

eitsupi commented Jul 4, 2023

Thank you for considering this!
I honestly don't know the criteria for inclusion in DESCRIPTION in general, so I can't say, but in terms of contact information, it might make sense since I have some understanding of the code base.


Could you also consider adding @etiennebacher to aut or ctb?
The website using altdoc is to @etiennebacher's credit.

@etiennebacher
Copy link
Collaborator

etiennebacher commented Jul 4, 2023

Could you also consider adding @etiennebacher to aut or ctb?

I don't mind being listed or not being listed in DESCRIPTION, but if you choose to put me in, ctb feels more appropriate

@grantmcdermott
Copy link
Collaborator

grantmcdermott commented Jul 4, 2023

+1 to @etiennebacher's comment. I'm grateful to be included as a contributor (ctb) and this corresponds to my understanding of the R package contribution conventions... but won't lose any sleep if not. I imagine the same is true for @vincentarelbundock.

@sorhawell and @eitsupi as dual authors/maintainers feels very appropriate. Thanks to you both for your tireless work on this cool project!

@sorhawell
Copy link
Collaborator Author

I looked at commit statistics and considered consistent cutoff rules. I have added only etiennerbacher as ctb as otherwise likely a handful more ctb's should be added immediately.

The package鈥檚 DESCRIPTION file must show both the name and email address of a single designated maintainer (a person, not a mailing list)

I will remain the 'cre'. If it becomes relevant, I don't mind swapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants