Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<LazyFrame>$fetch() #319

Merged
merged 21 commits into from
Aug 30, 2023
Merged

<LazyFrame>$fetch() #319

merged 21 commits into from
Aug 30, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Jul 10, 2023 •
edited by etiennebacher
Loading

Close #283

@sorhawell
Copy link
Collaborator Author

tests and better docs missing

etiennebacher
etiennebacher reviewed Jul 10, 2023
View reviewed changes
R/dataframe__frame.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher changed the title <LazyFrame>$fetch() + <DataFrame>$fetch() <LazyFrame>$fetch() Jul 27, 2023
@sorhawell sorhawell self-assigned this Aug 1, 2023
sorhawell and others added 7 commits August 8, 2023 15:35
@sorhawell
merge main
626d426 
Merge branch 'main' into dataframe-fetch

# Conflicts:
#	R/dataframe__frame.R
#	R/extendr-wrappers.R
#	R/lazyframe__lazy.R
#	src/rust/src/lazy/dataframe.rs
@sorhawell
solve conflicts + drop DataFrame_fetch
48b953d
@sorhawell
unit-test + roxygen
33fdb30
@etiennebacher
Merge branch 'main' into dataframe-fetch
8f475fb
@sorhawell
merge main re-solve conflicts
cd2285c 
Merge remote-tracking branch 'origin/main' into dataframe-fetch

# Conflicts:
#	R/extendr-wrappers.R
#	R/lazyframe__lazy.R
#	src/rust/src/lazy/dataframe.rs
@sorhawell
support fetch with R + extra unit tests + docs
cc128c1
@sorhawell
fmt + opt args + docs
ab8ddf6
@sorhawell sorhawell marked this pull request as ready for review August 10, 2023 13:04
@sorhawell
tniy bug in a utest
6f8a672
@sorhawell
merge main solve conflicts
025d26a 
Merge remote-tracking branch 'origin/main' into dataframe-fetch

# Conflicts:
#	R/lazyframe__lazy.R
#	man/LazyFrame_collect.Rd
#	src/rust/src/lazy/dataframe.rs
This was referenced Aug 12, 2023
Merged
Closed
@etiennebacher etiennebacher mentioned this pull request Aug 24, 2023
Merged
sorhawell and others added 6 commits August 28, 2023 14:07
@sorhawell
fix error__trait.R docs error
ed341d4
@sorhawell
add news
f6c73fb
@sorhawell
upadate docs
0897b89
@sorhawell
with last
083245b
@etiennebacher
Merge branch 'main' into dataframe-fetch
de75c8d
@etiennebacher
fix conflicts with main
e694a30 
Merge branch 'main' into dataframe-fetch

# Conflicts:
#	NEWS.md
#	R/extendr-wrappers.R
#	man/where_in.Rd
etiennebacher

This comment was marked as outdated.

Sign in to view

@etiennebacher etiennebacher mentioned this pull request Aug 30, 2023
Merged
etiennebacher
etiennebacher approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @sorhawell

@etiennebacher etiennebacher merged commit afb7650 into main Aug 30, 2023
11 checks passed
@etiennebacher etiennebacher deleted the dataframe-fetch branch August 30, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees

@sorhawell sorhawell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement $fetch()
2 participants
@sorhawell @etiennebacher