Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rust-polars to 0.32.0 #334

Merged
merged 26 commits into from
Aug 29, 2023
Merged

bump rust-polars to 0.32.0 #334

merged 26 commits into from
Aug 29, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Jul 24, 2023

Close #324

@sorhawell
Copy link
Collaborator Author

new cargo.toml inspired by pola-rs/nodejs-polars#85

@sorhawell sorhawell changed the title WIP: bump rust-polars to 0.31.1 WIP: bump rust-polars to 0.31.0 Jul 24, 2023
R/expr__expr.R Outdated Show resolved Hide resolved
@etiennebacher
Copy link
Collaborator

FYI Polars 0.32.0 was released today. I don't know how much work it is to bump from 0.30.0 to 0.32.0 but it would be really cool to catch up

@sorhawell
Copy link
Collaborator Author

Ha then I don't have to do 31 ;)

@sorhawell sorhawell changed the title WIP: bump rust-polars to 0.31.0 WIP: bump rust-polars to 0.32.0 Aug 21, 2023
…mat, LazyFrame_sort, add Err_plain shorthand, refactor strftime strptime, date_range, $all() $any() has now drop_nulls=TRUE arg, refactor json_extract, common_subplan_eliminatino -> (comm_subplan_elim + comm_subexpr_elim) + docs + fix tests
@sorhawell
Copy link
Collaborator Author

this takes ages alot of breaking changes in rust-polars to fix, but getting there ...

10 unit tests left to fix

@etiennebacher
Copy link
Collaborator

That's some huge work, thanks! Given the number of breaking changes, I think it would be nice to merge this after 0.8.0 is released. What do you think about this?

If you agree, there are #319 and #361 to merge first (cf your list in #364), are these ready for review?

@sorhawell
Copy link
Collaborator Author

@etiennebacher yeah lets see if we can get them done next week

MSRV test points to rust-polars 32 needs something later than rust 1.65. That might become an issue R-universe and CRAN

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 27, 2023

MSRV test points to rust-polars 32 needs something later than rust 1.65. That might become an issue R-universe and CRAN

I think there is no problem on R-universe because the R-universe's builder is currently installed with the latest Rust.
https://github.com/r-universe-org/base-image/blob/58425379cb893b458cdb5951aeb4945120268a84/Dockerfile#L124-L125

Let's forget about CRAN :)

README.Rmd Outdated Show resolved Hide resolved
@sorhawell sorhawell changed the title WIP: bump rust-polars to 0.32.0 bump rust-polars to 0.32.0 Aug 28, 2023
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
It seems working fine. Is there any reason why this is still a draft?

@sorhawell sorhawell marked this pull request as ready for review August 28, 2023 14:14
@sorhawell
Copy link
Collaborator Author

Thanks for working on this!
It seems working fine. Is there any reason why this is still a draft?

Oups, now marked for review :)

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 28, 2023

I wonder this will also close #324?

@etiennebacher

This comment was marked as outdated.

Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tweaked the NEWS a bit, that's massive so I'd say let's trust the test suite here 😅 thanks @sorhawell !

src/rust/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor updates.
(At first, I installed polars from crates.io, but it didn't work...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump rust-polars 0.31.0
3 participants