Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sink stream for LazyFrame #343

Merged
merged 14 commits into from
Aug 11, 2023
Merged

Implement sink stream for LazyFrame #343

merged 14 commits into from
Aug 11, 2023

Conversation

Sicheng-Pan
Copy link
Collaborator

#260

Implements sink_ipc and sink_parquet for LazyFrame

src/rust/src/lazy/dataframe.rs Outdated Show resolved Hide resolved
src/rust/src/lazy/dataframe.rs Outdated Show resolved Hide resolved
tests/testthat/test-sink_stream.R Show resolved Hide resolved
R/lazyframe__lazy.R Show resolved Hide resolved
src/rust/src/lazy/dataframe.rs Outdated Show resolved Hide resolved
src/rust/src/lazy/dataframe.rs Outdated Show resolved Hide resolved
@sorhawell
Copy link
Collaborator

@Sicheng-Pan thankyou for looking into this.

I guess this PR is missing #323 to allow all optimization args. I have just updated #323 and will merge asap

Copy link
Collaborator

@sorhawell sorhawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect by adding opt-toggles the warning in unittest should go away. At least if explicitly choosing no CSE. Then PR is good.

src/rust/src/rdatatype.rs Outdated Show resolved Hide resolved
R/lazyframe__lazy.R Outdated Show resolved Hide resolved
R/lazyframe__lazy.R Outdated Show resolved Hide resolved
@sorhawell sorhawell merged commit fc18efd into main Aug 11, 2023
11 checks passed
@sorhawell sorhawell deleted the sink_stream branch August 11, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants