Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix named_exprs not allowed and any related error #357

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Aug 9, 2023

Close #356

Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix @sorhawell. Can I merge this now or do I wait for #356 (comment)?

@sorhawell
Copy link
Collaborator Author

sorhawell commented Aug 9, 2023

Can I merge this now or do I wait for #356 (comment)?

I think this PR is good to merge. Did not find any other place named expressions should be added. explode became a side story. Previous error was likely download a csv from internet.

@sorhawell sorhawell merged commit 8de9d98 into main Aug 9, 2023
11 checks passed
@sorhawell sorhawell deleted the rework_named_exprs branch August 9, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency of with_columns() and agg() about named expressions
2 participants