Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated $with_column() and subnamespace $arr #402

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

etiennebacher
Copy link
Collaborator

@sorhawell apparently Expr_list is defined twice and the first definition is a deprecated function (no idea since when it's deprecated):

r-polars/R/expr__expr.R

Lines 4224 to 4230 in 33a56d9

Expr_list = function() {
if (is.null(runtime_state$warned_deprecate_list)) {
runtime_state$warned_deprecate_list = TRUE
warning("polars pl$list and <Expr>$list are deprecated, use $implode instead.")
}
self$implode()
}

Do you want to remove this now?

@sorhawell
Copy link
Collaborator

oh yes the expression <Expr>$list was deprecated/renamed in py-polars to <Expr>$implode() we followed suit already in r-polars 0.6.0 4 months ago

We accidentially hard removed it from 0.8.1 when renaming arr to list but that was about to some no harm is done.

We can delete Expr_list, yes.

@sorhawell
Copy link
Collaborator

Looks good to me :)

@etiennebacher etiennebacher merged commit 1f6ec5b into main Sep 29, 2023
11 checks passed
@etiennebacher etiennebacher deleted the remove-deprecated branch September 29, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants