-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add configure scripts and update CI #435
Conversation
e5454dd
to
d595159
Compare
The release workflow seems to be building the library twice. It needs to be fixed. |
Merging this PR should reduce CI execution time due to Rust caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much in bash so I can't properly review this but reducing CI time would be great. It looks like it still takes about 20min in this PR, is it because it has to rebuild everything before caching is used?
Also, I didn't understand why we bumped the required R version to 4.2. I'd rather keep it 4.1 if there are no reasons other than for CI.
I think that's why it hasn't been saved yet because the cache is only saved from the main branch.
To support R 4.1, the Makevars file for Windows must be split into Also, the latest version of libR-sys no longer supports R 4.1 (extendr/libR-sys#170), so it will be necessary to end support for R 4.1 in the near future. |
Part of #408, close #431
Port the configure scripts and GitHub Actions workflows from https://github.com/eitsupi/prqlr.