Implement .pr$DataFrame$drop_all_in_place()
#504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Thanks! I think this is useful.
@etiennebacher Any thoughts?
|
I'll add a few comments in a couple of hours |
etiennebacher
approved these changes
Nov 13, 2023
etiennebacher
changed the title
.pr$DataFrame$drop_all_in_place(my_df).pr$DataFrame$drop_all_in_place()
|
Ready for merge after checks |
Merge remote-tracking branch 'origin/main' into release_me # Conflicts: # NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support dropping pl::DataFRame inside RPolarsDataFrame to assist rpolars/r-polarssql#2
No news because it is an internal method.
If r-polarssql chooses to rely on this method, add comment to not break behavior.