Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the argument to_supertypes in pl$concat() #523

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

etiennebacher
Copy link
Collaborator

Close #520

@sorhawell I didn't see plans to expose the arg to_supertypes in issues / PRs in the rust-polars repo, so I think we should match the Python API for now, and reexpose this arg later if they do so.

We still don't have how = "align".

@etiennebacher etiennebacher marked this pull request as ready for review November 20, 2023 12:11
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher etiennebacher merged commit 3f13fd1 into main Nov 21, 2023
17 checks passed
@etiennebacher etiennebacher deleted the remove-to-supertypes branch November 21, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pl$concat()'s arguments
2 participants