Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $apply() and $map() to $map_elements() and $map_batches() #534

Merged
merged 14 commits into from
Nov 28, 2023

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Nov 21, 2023

Close #512

We haven't implemented $apply() for DataFrame or Groupby yet. I also cleaned the docs of both methods.

@sorhawell
Copy link
Collaborator

Feel free to drop any example from map/apply you don't see necessary. Some of these examples I think take a little too long to run CI-wise.

@etiennebacher
Copy link
Collaborator Author

Some of these examples I think take a little too long to run CI-wise.

Yes but they are still useful I think, maybe I'll move them in a "tips and tricks" vignette with your examples for $transpose()

@etiennebacher etiennebacher mentioned this pull request Nov 22, 2023
@eitsupi eitsupi added this to the 0.11 milestone Nov 22, 2023
@eitsupi eitsupi modified the milestone: 0.11 Nov 26, 2023
@etiennebacher etiennebacher removed this from the 0.11 milestone Nov 27, 2023
@etiennebacher
Copy link
Collaborator Author

etiennebacher commented Nov 28, 2023

@eitsupi sorry I forgot again, should I bump r-polars version in cargo.toml to 0.36.0 or 0.35.1? (I did 0.36.0 for now)

@eitsupi
Copy link
Collaborator

eitsupi commented Nov 28, 2023

Actually, we are only looking at different version numbers here, so it should not be the same number, but 0.35.1 is a good choice to match the minor version of rust-polars.

if (identical(current_lib_version, latest_released_lib_version)) {

@etiennebacher etiennebacher marked this pull request as ready for review November 28, 2023 07:49
NEWS.md Show resolved Hide resolved
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi merged commit 1949248 into main Nov 28, 2023
31 checks passed
@eitsupi eitsupi deleted the deprecate-apply-map branch November 28, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the $map() and $apply() Expr and variants
3 participants