Implement $str$to_date(), $str$to_time(), $str$to_datetime()
#558
Conversation
Merge branch 'main' into to-date # Conflicts: # R/extendr-wrappers.R
etiennebacher
changed the title
$str$to_date() and $str$to_datetime()$str$to_date(), $str$to_time(), $str$to_datetime()
| ExprStr_to_date = function(format = NULL, strict = TRUE, exact = TRUE, cache = TRUE) { | ||
| .pr$Expr$str_to_date(self, format, strict, exact, cache) |> | ||
| unwrap("in $str$to_date():") | ||
| } |
There was a problem hiding this comment.
Probably applicable to other functions as well, but such functions may be better off using ... to enforce named arguments.
There was a problem hiding this comment.
but then you lose the description of each param in the docs, no? In any case, if that concerns several other functions it can be done in another PR so I'm merging this
There was a problem hiding this comment.
but then you lose the description of each param in the docs, no?
I'm sorry, but I don't understand. Here's what I mean:
ExprStr_to_date = function(..., format = NULL, strict = TRUE, exact = TRUE, cache = TRUE)There was a problem hiding this comment.
Oh right, could be added later but that could also apply to basically all functions that have several args
There was a problem hiding this comment.
Agree.
I think it's safer to do this for most of the functions that have a lot of arguments.
They were already there but not available through the namespace
$strbecause they were only used in$str$strptime()Also updated the arguments because some were deprecated/removed upstream