feat: rownames option and make_names_unique option of as_polars_df
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
commented
Dec 3, 2023
eitsupi
changed the title
rownames option of as_polars_dfrownames option and make_names_unique of as_polars_df
eitsupi
changed the title
rownames option and make_names_unique of as_polars_dfrownames option and make_names_unique option of as_polars_df
etiennebacher
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
tibble::as_tibble'srownamesargument.However, it differs in that it implicitly overwrites existing column (
as_tibbleholds two columns have same name, andtibble::rownames_to_columnraise an error).-> Update: Raise an error for the name is already used as like
tibble::rownames_to_column.